This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Communities v2 prototype: Override invite aesthetics for community-as-room invites - #5143
Merged
Merged
Conversation
jryans
approved these changes
Aug 26, 2020
| const profile = await this.matrixClient._http.authedRequest( | ||
| undefined, "GET", path, | ||
| undefined, undefined, | ||
| {prefix: "/_matrix/client/unstable/im.vector.custom"}); |
Collaborator
There was a problem hiding this comment.
No particular need to change anything now, but just pointing out that im.vector should probably be replaced with io.element for new work.
Member
Author
There was a problem hiding this comment.
👍 will keep in mind for the next one (which should hopefully not need a generic custom namespace and instead can be associated to an MSC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype behaviour:
(If you're wondering why the screenshots don't look confusing then the PR is doing its job)