Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Switch out the globe icon and colour it depending on theme - #5106

Merged
t3chguy merged 4 commits into
developfrom
t3chguy/room-list/14608
Aug 14, 2020
Merged

Switch out the globe icon and colour it depending on theme#5106
t3chguy merged 4 commits into
developfrom
t3chguy/room-list/14608

Conversation

@t3chguy

@t3chguy t3chguy commented Aug 13, 2020

Copy link
Copy Markdown
Member

Fixes element-hq/element-web#14608

  • Figure out how to clip out the cut-out so that the background is visible through it

image
image

Consolidates RoomTileIcon into its parent as we need to know the state cleanly

@t3chguy
t3chguy marked this pull request as ready for review August 14, 2020 09:32
@t3chguy
t3chguy requested review from a team August 14, 2020 09:33

@jryans jryans left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😄

@t3chguy
t3chguy requested review from niquewoodhouse and removed request for a team August 14, 2020 17:09

@niquewoodhouse niquewoodhouse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t3chguy
t3chguy merged commit be1d390 into develop Aug 14, 2020
@t3chguy
t3chguy deleted the t3chguy/room-list/14608 branch August 14, 2020 17:11
@532910

532910 commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

It's anything but not a globe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new globe icons are unrecognizable

4 participants