This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Create Map comparison utilities and convert Hooks to Typescript - #5086
Merged
Conversation
JorikSchellekens
suggested changes
Aug 5, 2020
JorikSchellekens
left a comment
JorikSchellekens
left a comment
Contributor
There was a problem hiding this comment.
Just a question about the unused functions here
| if (doUpdate) { | ||
| // We have to break our reference to the room list store if we want to be able to | ||
| // diff the object for changes, so do that. | ||
| // @ts-ignore - ITagMap is ts-ignored so this will have to be too |
Contributor
There was a problem hiding this comment.
Not looking to change it but :'(
| * @param b The second Map. Must be defined. | ||
| * @returns The difference between the keys of each Map. | ||
| */ | ||
| export function mapDiff<K, V>(a: Map<K, V>, b: Map<K, V>): { changed: K[], added: K[], removed: K[] } { |
Contributor
There was a problem hiding this comment.
It doesn't look like anything is using these?
Member
Author
There was a problem hiding this comment.
Correct you are, #4745 does and just plucked out the reusable stuff to shrink the diff of that mammoth
Contributor
There was a problem hiding this comment.
Damn, that is hefty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset of #4745