This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Make reply preview not an overlay so you can see new messages - #5072
Merged
Conversation
As users can't scroll down all the way down to the timeline like this to see the last message (and perhaps adjust their reply to it) This also remove the wrapper div as it is not needed anymore
…the bottom this way new messages will appear in the timeline without needing to scroll
Member
|
The composer buttons getting moved up looks really broken |
…'t get centered with it
Contributor
Author
This should be fixed now:
|
Contributor
Author
|
(@niquewoodhouse has already approved the design OOB) |
Member
|
Should autocomplete panes get the same treatment? |
turt2live
approved these changes
Jul 31, 2020
turt2live
left a comment
turt2live
left a comment
Member
There was a problem hiding this comment.
otherwise lgtm. I'm impressed at how simple it is!
Contributor
Author
Good idea, but not sure I want to put in the time now, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up during the polish call with @niquewoodhouse