Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add 'startAtBottom' flag #483

Merged
merged 2 commits into from
Sep 16, 2016
Merged

Add 'startAtBottom' flag #483

merged 2 commits into from
Sep 16, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 16, 2016

Controls whether a scrollPanel starts off at the bottom.

This may not be necessary and could either be derived from stickyBottom, but
this means I can be sure that the behaviour of ScrollPanel is completely
unchanged for all other uses to avoid breaking any other uses of
ScrollPanel.

Controls whether a scrollPanel starts off at the bottom.

This may not be necessary and could either be derived from stickyBottom, but
this means I can be sure that the behaviour of ScrollPanel is completely
unchanged for all other uses to avoid breaking any other uses of
ScrollPanel.
@richvdh
Copy link
Member

richvdh commented Sep 16, 2016

I think you probably just wanted this.scrollState = {stuckAtBottom: this.props.stickyBottom}. I understand your conservatism, however. On the other hand I'd prefer it if the comments saying that you think it's just conservatism made it into the code rather than being lost in the PR.

@dbkr
Copy link
Member Author

dbkr commented Sep 16, 2016

Good point: documented on the param

@ara4n
Copy link
Member

ara4n commented Sep 16, 2016

lgtm

@ara4n ara4n merged commit 00d2fd4 into develop Sep 16, 2016
@richvdh richvdh deleted the dbkr/scrollpanel_start_at_bottom branch February 15, 2017 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants