This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix: conference rooms were no longer hidden #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| getOnlyOtherMember(room, me) { | ||
| const joinedMembers = room.getJoinedMembers(); | ||
|
|
||
| if (joinedMembers.length === 2) { |
There was a problem hiding this comment.
hrmmm.... what will this do if you are invited to a room with two other members?
There was a problem hiding this comment.
Good point - should be easy to check
|
lgtm modulo comment |
|
Does this seem reasonable? |
I guess so. I'm slightly sad that the implementation of "getOnlyOtherMember" doesn't really match the name or the comment, but it's certainly fine for what you're using it for. I'm happy for it to stay like this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.