This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Support sending config and ready events to capable widgets (Jitsi) #4266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
approved these changes
Mar 25, 2020
| } | ||
| } else if (action === 'get_openid') { | ||
| // Handled by caller | ||
| } else if (action === KnownWidgetActions.GetRiotWebConfig) { |
Member
There was a problem hiding this comment.
can this get switch'd for readability?
Member
Author
There was a problem hiding this comment.
Switch statements are less readable imo :(
Member
There was a problem hiding this comment.
I'm happy for this to land as is, we need to decide as a team whether we do or do not use switches in that case. (and be consistent with that choice)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review with element-hq/element-web#12845