This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Amends react template and removes opening image in lightbox #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| render: function() { | ||
| var p = this.state.preview; | ||
| if (!p) return <div/>; | ||
|
|
||
| // FIXME: do we want to factor out all image displaying between this and MImageBody - especially for lightboxing? | ||
| var image = p["og:image"]; | ||
| var imageMaxWidth = 100, imageMaxHeight = 100; | ||
| var imageMaxWidth = 600, imageMaxHeight = 400; |
There was a problem hiding this comment.
This feels strange to me, I wouldn't fix any dimensions. Is this to keep the scroll position behaving?
There was a problem hiding this comment.
yes it is. this would force all previews to be 400px huge i think? unless you changed the css for this, in which case it will probably break scroll pos. will test
There was a problem hiding this comment.
going to merge this and see what breaks.
|
lgtm other than q's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style amends in element-hq/element-web#1799
Signed-off-by: Stefan Pearson stefan@ribot.co.uk