This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Overwrite the old session if the new creds are for a different user #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the HS implementation doesn't respect the device_id parameter erroneously
|
@bwindels I've included a device ID check in this - please take a look. Edit: rationale for wiping when the device ID differs is that our current keys are useless and unusable, so we might as well throw them away. Once again, we could prompt the user and say "hey, you're about to do something dumb" but at this point the homeserver is unlikely to support what we want it to and the user can't do anything about it. |
bwindels
approved these changes
Jul 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10272
Based on #3182 (see commits after merge commit)