This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add View Servers in Room to Devtools #2804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
suggested changes
Mar 19, 2019
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Generally looks okay, just a couple code quality things to resolve.
Thanks for taking this on!
| constructor(props, context) { | ||
| super(props, context); | ||
|
|
||
| this.onQuery = this.onQuery.bind(this); |
Member
There was a problem hiding this comment.
we've since changed how we do this kind of binding. Instead, it is preferred to be represented as:
onQuery = (query) => {
// do stuff
};
…ix-org/matrix-react-sdk into devtools_serverlist
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9194
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com