Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Avoid rerendering EventTiles when not necessary #278

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 19, 2016

Each individual eventtile isn't particularly expensive, but when you have 500
of them, they start adding up. Shuffle some of the stuff into MessagePanel, so
that we can shouldComponentUpdate EventTiles properly.

Each individual eventtile isn't particularly expensive, but when you have 500
of them, they start adding up. Shuffle some of the stuff into MessagePanel, so
that we can shouldComponentUpdate EventTiles properly.
@ara4n ara4n assigned ara4n and unassigned dbkr Apr 19, 2016
@ara4n
Copy link
Member

ara4n commented Apr 19, 2016

lgtm, although i'm a bit surprised this is needed and is easier than fixing whatever has increased the timeline-rerendering regression in the first place?

@ara4n ara4n assigned richvdh and unassigned ara4n Apr 19, 2016
@ara4n
Copy link
Member

ara4n commented Apr 19, 2016

hm, is this going to handle the redraw required when a LinkPreviewWidget finishes loading ok?

@richvdh
Copy link
Member Author

richvdh commented Apr 19, 2016

hm, is this going to handle the redraw required when a LinkPreviewWidget finishes loading ok?

what redraw? The LinkPreviewWidget itself will need a re-render, but it handles that itself. There is no need for EventTile to re-render at this stage.

@richvdh richvdh merged commit b0eba8a into develop Apr 19, 2016
@richvdh richvdh deleted the rav/optimise_eventtile_update branch April 19, 2016 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants