Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Only show the first line of each commit in changelog dialog #2667

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Feb 20, 2019

Multi-line commits aren't actually formatted correctly, and most likely the
first line is enough of a summary anyway, so this change trims to the first
line. The commits are linked, so you can click through if you want more detail.

Fixes element-hq/element-web#8285

Multi-line commits aren't actually formatted correctly, and most likely the
first line is enough of a summary anyway, so this change trims to the first
line. The commits are linked, so you can click through if you want more detail.

Fixes element-hq/element-web#8285
@jryans jryans requested a review from a team February 20, 2019 12:23
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just thinking if the message could be null or undefined, but don't think so?

@jryans
Copy link
Collaborator Author

jryans commented Feb 20, 2019

if the message could be null or undefined

git itself seems to abort if the message is empty... I am hoping all our commits will have messages, even if there is some way to force an empty one, so I think it's okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants