Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add redesigned dark theme - #2619

Merged
jryans merged 26 commits into
developfrom
jryans/dark-theme-redesign
Feb 13, 2019
Merged

Add redesigned dark theme#2619
jryans merged 26 commits into
developfrom
jryans/dark-theme-redesign

Conversation

@jryans

@jryans jryans commented Feb 12, 2019

Copy link
Copy Markdown
Collaborator

This adds the new unified palette to the dark theme to define a few top level colors and let those flow down to the more specific color names. It also updates some global colors (like accent) that are the same for all themes. Many more icons are also converted to mask in CSS approach to support easy theming.

image

Used in element-hq/element-web#8540
Implements the bulk of element-hq/element-web#7578

@jryans
jryans requested a review from a team February 12, 2019 18:18
@dbkr dbkr self-assigned this Feb 12, 2019
@aaronraimist

aaronraimist commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

screen shot 2019-02-12 at 5 30 25 pm
It would be nice to use a white [m] logo in the room directory

@aaronraimist

Copy link
Copy Markdown
Contributor

Also the LLP is still using a black scroll bar for me

@aaronraimist

aaronraimist commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

screen shot 2019-02-12 at 5 36 41 pm
screen shot 2019-02-12 at 5 37 16 pm

Should there be a more visible vertical line here?

@aaronraimist

Copy link
Copy Markdown
Contributor

screen shot 2019-02-12 at 5 40 55 pm

On the Create Community page, it is quite hard to read the + and domain

@aaronraimist

aaronraimist commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

screen shot 2019-02-12 at 5 52 58 pm

screen shot 2019-02-12 at 5 54 15 pm

Placeholder text is hard to read

@aaronraimist

Copy link
Copy Markdown
Contributor

Editing an event in developer tools is hard to read
screen shot 2019-02-12 at 5 56 16 pm

@aaronraimist

aaronraimist commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

screen shot 2019-02-12 at 6 04 09 pm
The markdown button status appears to be reversed

and when markdown is disabled these formatting buttons are hard to see
screen shot 2019-02-12 at 6 05 08 pm

@ara4n

ara4n commented Feb 13, 2019

Copy link
Copy Markdown
Member

@nadonomy in terms of feedback on the overall theme design, i think we also need to make the hairlines more visible for dragging purposes - plus i wonder if we're too high contrast, at least for a dark theme, especially when compared with the old dark theme. This feels more like a black theme to me?

I wonder whether the less contrasty primary bg/fg colours from jouni's mockup might be helpful:

screenshot 2019-02-12 at 17 39 19

@nadonomy

nadonomy commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

@nadonomy in terms of feedback on the overall theme design, i think we also need to make the hairlines more visible for dragging purposes - plus i wonder if we're too high contrast, at least for a dark theme, especially when compared with the old dark theme. This feels more like a black theme to me?

I wonder whether the less contrasty primary bg/fg colours from jouni's mockup might be helpful:

screenshot 2019-02-12 at 17 39 19

Increasing the legibility of the hairlines is a no brainer but let's chat more on Riot about the overall darkness and fg/bg colours as they're extremely multifactorial (unifying accent colours across themes, platforms and branding, avoiding 'shoulder surfing' similarity to Discord, Ryan's screenshot taken in FF with heavier font rendering, exacerbating the contrast compared to the Sketch comp with lighter weights and lashings of negative space... and perhaps some subjectivity ;).

@jryans
jryans force-pushed the jryans/dark-theme-redesign branch from dd668d9 to 1359ac6 Compare February 13, 2019 10:52
@jryans

jryans commented Feb 13, 2019

Copy link
Copy Markdown
Collaborator Author

Thanks @aaronraimist for the early feedback! I had addressed some of the issues in this branch:

  • Composer icons (markdown disabled still needs some work though)
  • <textarea>, <input> text / placeholder color
  • Prefix / suffix on create community

For the others, let's track them elsewhere so the feedback isn't lost.

@jryans
jryans merged commit e6f9b7a into develop Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants