This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't reset cached room list values when they are falsey #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unread` and `unread-muted` store booleans in the cache, and can easily be `false`. Without this patch, both of those cached types would be cleared from the object where a later call to `getRoomState` would try and re-populate them. `getRoomState` is supposed to use the cache where possible to avoid making the more expensive calls required to calculate those booleans. On my account in a test environment, this brings the `generateRoomLists` execution time down from ~250ms to just ~30ms. This still does not solve the whole issue, but should solve the more common case of performance woes for people.
|
this looks plausible. isn't it more idiomatic to say |
|
For some reason I did a |
|
also there's a 90% chance I cut all this out later in the week. |
|
ok, lgtm (although would be interested to know what it's being replaced with) |
ara4n
approved these changes
Jan 8, 2019
|
It'll be replaced with something that doesn't calculate the room list from scratch every time the client sees an event. |
This was referenced Jan 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unreadandunread-mutedstore booleans in the cache, and can easily befalse. Without this patch, both of those cached types would be cleared from the object where a later call togetRoomStatewould try and re-populate them.getRoomStateis supposed to use the cache where possible to avoid making the more expensive calls required to calculate those booleans.On my account in a test environment, this brings the
generateRoomListsexecution time down from ~250ms to just ~30ms.This still does not solve the whole issue, but should solve the more common case of performance woes for people.
Should make the app more bearable (see element-hq/element-web#8033)