This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
render: function() { | ||
return ( | ||
<select className="mx_PresetOption" onChange={this.onValueChanged} defaultValue={this.state.preset}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably call this mx_Presets, ie matching the name of the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see the naming conventions in the README.md)
Apart from a couple of classNames, lgtm. |
erikjohnston
force-pushed
the
create_room
branch
from
July 14, 2015 16:51
0c4f302
to
01c7449
Compare
erikjohnston
force-pushed
the
create_room
branch
from
July 14, 2015 16:52
01c7449
to
4f7dcdf
Compare
alantygel
pushed a commit
to coletivoEITA/matrix-react-sdk
that referenced
this pull request
Apr 17, 2017
Change base branch
turt2live
pushed a commit
to turt2live/matrix-react-sdk
that referenced
this pull request
May 19, 2017
…ion-events Update branch to latest develop
t3chguy
added a commit
that referenced
this pull request
Jul 21, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
pushed a commit
that referenced
this pull request
Jan 31, 2022
AndrewRyanChama
pushed a commit
to AndrewRyanChama/matrix-react-sdk
that referenced
this pull request
Mar 2, 2022
Mark as unread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.