This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Warn users on unsupported browsers before they lack features #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
added
the
T-Enhancement
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
commented
Jul 26, 2024
Comment on lines
+73
to
+74
| "caniuse-lite": "1.0.30001643", | ||
| "electron-to-chromium": "1.5.2" |
There was a problem hiding this comment.
These are both transitive dependencies of browserslist and forcing resolution de-duplicates them in the bundle
|
This PR uses existing toast styles rather than the Figma ones, #12833 brings them back inline |
MidhunSureshR
approved these changes
Jul 29, 2024
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/element-hq/wat-internal/issues/222
Blocked on the
Learn morelink going nowhere useful