This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update for js-sdk interface change #12638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a separate method to force a capabilities fetch as of matrix-org/matrix-js-sdk#4246
dbkr
added
the
T-Task
t3chguy
reviewed
Jun 18, 2024
| @@ -55,7 +55,7 @@ export async function getServerVersionFromFederationApi(client: MatrixClient): P | |||
|
|
|||
| const ServerInfo: React.FC<IDevtoolsProps> = ({ onBack }) => { | |||
| const cli = useContext(MatrixClientContext); | |||
| const capabilities = useAsyncMemo(() => cli.getCapabilities(true).catch(() => FAILED_TO_LOAD), [cli]); | |||
| const capabilities = useAsyncMemo(() => cli.fetchCapabilities().catch(() => FAILED_TO_LOAD), [cli]); | |||
There was a problem hiding this comment.
Why fetch over get here? Wouldn't cached be fine?
There was a problem hiding this comment.
I'm not sure to be honest, the code seems to think it's necessary though: I'm just aiming for maintaining the same functionality.
t3chguy
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a separate method to force a capabilities fetch as of matrix-org/matrix-js-sdk#4246
Checklist
public/exportedsymbols have accurate TSDoc documentation.