Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move the TAC to above the button #12438

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Move the TAC to above the button #12438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3f7e1d
Move the TAC to above the button
dbkr Apr 18, 2024
6cf8667
Update snapshots
dbkr Apr 18, 2024
6aaa010
Merge branch 'develop' into dbkr/move_tac
dbkr Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,15 @@ export function ThreadsActivityCentre({ displayButtonLabel }: ThreadsActivityCen
</ReleaseAnnouncement>
) : (
<Menu
align="end"
align="start"
side="top"
open={open}
onOpenChange={(newOpen) => {
// Track only when the Threads Activity Centre is opened
if (newOpen) PosthogTrackers.trackInteraction("WebThreadsActivityCentreButton");

setOpen(newOpen);
}}
side="right"
title={_t("threads_activity_centre|header")}
trigger={
<ThreadsActivityCentreButton
Expand Down
12 changes: 6 additions & 6 deletions test/components/views/spaces/__snapshots__/ThreadsActivityCentre-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ exports[`ThreadsActivityCentre renders notifications matching the snapshot 1`] =
aria-labelledby="radix-14"
aria-orientation="vertical"
class="_menu_1x5h1_17"
data-align="end"
data-align="start"
data-orientation="vertical"
data-radix-menu-content=""
data-side="right"
data-side="top"
data-state="open"
dir="ltr"
id="radix-15"
Expand Down Expand Up @@ -130,10 +130,10 @@ exports[`ThreadsActivityCentre should match snapshot when empty 1`] = `
aria-labelledby="radix-20"
aria-orientation="vertical"
class="_menu_1x5h1_17"
data-align="end"
data-align="start"
data-orientation="vertical"
data-radix-menu-content=""
data-side="right"
data-side="top"
data-state="open"
dir="ltr"
id="radix-21"
Expand Down Expand Up @@ -164,10 +164,10 @@ exports[`ThreadsActivityCentre should order the room with the same notification
aria-labelledby="radix-22"
aria-orientation="vertical"
class="_menu_1x5h1_17"
data-align="end"
data-align="start"
data-orientation="vertical"
data-radix-menu-content=""
data-side="right"
data-side="top"
data-state="open"
dir="ltr"
id="radix-23"
Expand Down
Loading