This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make empty state copy for TAC depend on the value of the setting #12419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
added
the
T-Enhancement
Run the whole file or the radix IDs will br wrong 🤦
| @@ -52,6 +53,15 @@ export function ThreadsActivityCentre({ displayButtonLabel }: ThreadsActivityCen | |||
| const [open, setOpen] = useState(false); | |||
| const roomsAndNotifications = useUnreadThreadRooms(open); | |||
| const isReleaseAnnouncementOpen = useIsReleaseAnnouncementOpen("threadsActivityCentre"); | |||
| const settingTACOnlyNotifs = useSettingValue<boolean>("Notifications.tac_only_notifications"); | |||
|
|
|||
| const emptyCaption = useCallback((): string => { | |||
There was a problem hiding this comment.
The usage of useCallback seems too much for me in this use case.
A simple ternary/if is enough I think
florianduros
approved these changes
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy is suggested by David L and not fully signed off by design / product yet, but it is easy to change if it needs to be tweaked.
Checklist
public/exportedsymbols have accurate TSDoc documentation.