This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix thread navigation in timeline - #12412
Merged
Merged
Conversation
florianduros
added
the
T-Defect
florianduros
changed the title
florianduros
force-pushed
the
florianduros/fix/thread-panel
branch
from
April 11, 2024 14:53
398d10b to
3220a6d
Compare
florianduros
force-pushed
the
florianduros/fix/thread-panel
branch
2 times, most recently
from
April 11, 2024 16:37
fe8fd57 to
d3e17bb
Compare
florianduros
force-pushed
the
florianduros/fix/thread-panel
branch
from
April 11, 2024 16:47
d3e17bb to
f5f6904
Compare
florianduros
force-pushed
the
florianduros/fix/thread-panel
branch
from
April 12, 2024 07:45
f5f6904 to
ee56300
Compare
florianduros
marked this pull request as ready for review
April 12, 2024 08:07
dbkr
approved these changes
Apr 12, 2024
dbkr
left a comment
dbkr
left a comment
Member
There was a problem hiding this comment.
Thanks for adding the playwright test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Closes element-hq/element-web#27271
The deleted code seems to only cause trouble. I added an e2e test which is opening thread from the main timeline, closing thread, displaying the threads panel, opening threads from the thread panel.
This test https://github.com/matrix-org/matrix-react-sdk/blob/develop/playwright/e2e/read-receipts/new-messages.spec.ts#L233 is opening thread from the URL (
jumpTo).