This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Call Guest Access, give user the option to change the acces level so they can generate a call link. #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
added
the
T-Enhancement
toger5
force-pushed
the
toger5/ask-to-convert-v2
branch
from
6cfd1ad
to
e8e2121
Compare
robintown
reviewed
Apr 4, 2024
robintown
approved these changes
Apr 5, 2024
robintown
reviewed
Apr 5, 2024
toger5
force-pushed
the
toger5/ask-to-convert-v2
branch
from
3a2ceef
to
a4c9cac
Compare
Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: Robin <robin@robin.town>
Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: Robin <robin@robin.town>
Co-authored-by: Robin <robin@robin.town>
Changing power level did not update the ui. Signed-off-by: Timo K <toger5@hotmail.de>
toger5
force-pushed
the
toger5/ask-to-convert-v2
branch
from
a7218de
to
98f2dbc
Compare
Signed-off-by: Timo K <toger5@hotmail.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the room is not set to public or Knock invite rules one cannot share a call link.
This pr still shows the invite link button. Clicking will prompt the user to update their join rules to Knock (if enabled) or Public. If the user decides to do so the share dialog will be shown.
The share button is now only not visible if the user cannot change the join rules and the join rule is private.
screenshot:
Old screenshot
Checklist
public/exportedsymbols have accurate TSDoc documentation.