This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix video rooms not showing share link button #12374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
added
the
T-Defect
dbkr
approved these changes
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video rooms are not marked as
isViewingCall() === true.So they did not show the share link button.
changed the logic to:
isViewingCall() || isVideoRoom(room)Should we consider changing isViewingCall to already do the check if the room is a video room?
Signed-off-by: Timo K toger5@hotmail.de
Checklist
public/exportedsymbols have accurate TSDoc documentation.