This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Change user permission by using a new apply button - #12346
Merged
florianduros merged 7 commits intoMar 19, 2024
Conversation
florianduros
force-pushed
the
florianduros/fix/role-permission-selection
branch
from
March 15, 2024 16:21
a4597ab to
61c2973
Compare
florianduros
added
the
T-Enhancement
florianduros
force-pushed
the
florianduros/fix/role-permission-selection
branch
2 times, most recently
from
March 15, 2024 16:26
cc6f726 to
9c89d35
Compare
florianduros
force-pushed
the
florianduros/fix/role-permission-selection
branch
from
March 15, 2024 16:57
79a6ff2 to
ac95e41
Compare
It's extracting the current behavior of the privileged users and muted of `RolesRoomSettingsTab.tsx` into a dedicated component. It's also adding a new apply button.
…esRoomSettingsTab`
florianduros
force-pushed
the
florianduros/fix/role-permission-selection
branch
from
March 18, 2024 11:02
ac95e41 to
8d6d935
Compare
dbkr
approved these changes
Mar 19, 2024
dbkr
left a comment
dbkr
left a comment
Member
There was a problem hiding this comment.
I see, this did end up as quite a big change. Great to have that logic out of the room settings tab though.
| settings = await app.settings.openRoomSettings("Roles & Permissions"); | ||
| }); | ||
|
|
||
| test("should be able to change the role of an user", async ({ page, app, user }) => { |
Member
There was a problem hiding this comment.
minor grammar fix
Suggested change
| test("should be able to change the role of an user", async ({ page, app, user }) => { | |
| test("should be able to change the role of a user", async ({ page, app, user }) => { |
florianduros
enabled auto-merge
March 19, 2024 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Closes element-hq/element-web#27083
This PR adds an Apply button for editing the power level of privileged and muted users.
Privileged and muted users have a similar behavior in the current implementation. Only the listed users are changing.
This behavior is extracted into a new component
PowerLevelSelectorand the apply button is added.The button style when disabled is a bit different than the Add privileged user section. This button is using the new compound button component and the new design system style.