This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix alignment of user menu avatar #12289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12267 made the avatar a couple of pixels out of alignment with the space icons. It just needed to be moved 2px to the right to match the 18px margin of the space icons (including the padding from the black border). Also change elements in the user menu to block elements so they don't generate extra vertical space in the user menu div, which was causing the hairline to be too far down.
dbkr
added
the
T-Defect
robintown
reviewed
Feb 27, 2024
res/css/structures/_SpacePanel.pcss
Outdated
Comment on lines
400
to
401
| span, | ||
| img { |
There was a problem hiding this comment.
Could you target a class name here so we're not relying on the specific elements used in the Compound Avatar implementation?
There was a problem hiding this comment.
I can for the span, but the image only has an autogenerated class name. Unsure whether adding one just for this or just using the element type is the lesser evil. We could also match everything, which might actually be better?
There was a problem hiding this comment.
From my brief testing it looked like setting display: block only on the span was enough to fix the height, for what it's worth
There was a problem hiding this comment.
Huh, I retested and you're absolutely right.
robintown
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12267 made the avatar a couple of pixels out of alignment with the space icons. It just needed to be moved 2px to the right to match the 18px margin of the space icons (including the padding from the black border).
Also change elements in the user menu to block elements so they don't generate extra vertical space in the user menu div, which was causing the hairline to be too far down (unless anyone knows of a better way to avoid this extra height in the div: setting the hight of the div explicitly didn't work).
Checklist