Add Playwright tests for OIDC-aware & OIDC-native #12252
Conversation
t3chguy
added
the
T-Task
| const delegatedAuthAccountUrl = useAsyncMemo(async () => { | ||
| await sdkContext.oidcClientStore.readyPromise; // wait for the store to be ready | ||
| return sdkContext.oidcClientStore.accountManagementEndpoint; | ||
| }, [sdkContext.oidcClientStore]); | ||
| const disableMultipleSignout = !!delegatedAuthAccountUrl; |
There was a problem hiding this comment.
I haven't read through the whole class in detail, but won't setting delegatedAuthAccountUrl to undefined while we make a bunch of network requests mean that we display the wrong UI for a while? We need to distinguish between "we don't know yet" and "we're definitely not OIDC".
There was a problem hiding this comment.
Indeed, no design was given for this case so this is what we're going with for the time being.
Yup as per your ask on a different PR I split it into sane commits; so the actual main bit of the PR is the last commit - e13048d - the rest are all atomic building blocks for the test to work upon |
Well, separate commits are certainly helpful, but this is still an absolutely epic PR which is making a bunch of different changes. I really think it would be helpful to break it up into smaller PRs, to make the review cycle easier (as well as all the other usual reasons we use separate PRs rather than a single massive two-weekly PR). Please? |
… OIDC mode Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/e2e-oidc-aware
branch
from
effef3d
to
4d01fff
Compare
Stabilises raciness of the
Manage accountbutton in Settings alsoThis change is marked as an internal change (Task), so will not be included in the changelog.