fix automatic DM avatar with functional members

[HarHarLinks]

"Functional Members" is an Element feature that allows you to mark certain room members as bots or similar, allowing clients to exclude these members from things like autogenerated room names and avatars or could even be used to show that these members are not "natural person" users. The feature is described at https://github.com/element-hq/element-meta/blob/develop/spec/functional_members.md.

Element Web through the js and react SDKs already implements some of this feature, namely the exclusion from functional members from autogenerated room names. This PR expands the implementation for the avatar and presence dot.

before:

after:

needs: matrix-org/matrix-js-sdk#4017

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Kim Brose 2803622+HarHarLinks@users.noreply.github.com

---

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

[richvdh]

@HarHarLinks: sorry, I've not forgotten about this. I want to discuss it with the team a bit, though.

[HarHarLinks]

Thank you for the feedback, and based on your reaction I want to say sorry if the review pings were annoyingly sent repeatedly, I did not trigger them manually.

Please don't judge my code too harshly, this is my 3rd time or so messing with js/ts/react and I tried my hardest to figure it out and meet your standards.

I should note that the equivalent of this feature recently landed in Android 1.6.10 element-hq/element-android#8700 per element-hq/element-android#3736 and the first half, the removal of functional members' names from automatically generated room names has been present in web for a long time matrix-org/matrix-js-sdk#1771, so it would make sense to complete the feature, which is what I tried to do here. It is also implemented on iOS element-hq/element-ios#4643.

[richvdh]

Thank you for the feedback, and based on your reaction I want to say sorry if the review pings were annoyingly sent repeatedly, I did not trigger them manually.

Not at all. I just noticed this had already been sitting for a couple of weeks.

[richvdh]

Looks like the snapshot needs updating, and a couple of suggstions for the tests.

[richvdh]

Thanks very much for the contributions, by the way!

[HarHarLinks]

Thanks for the feedback, all 3 points should now have been addressed.

[richvdh]

lgtm. Thanks!

[richvdh]

@HarHarLinks this seems to be the victim of some flaky tests. I've re-run them, but if you notice them blocking this PR again, please ping us.

[richvdh]

Still failing :(

cf element-hq/element-web#27075, element-hq/element-web#27076