Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow Chrome page translator to translate messages in rooms #11113

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Allow Chrome page translator to translate messages in rooms #11113

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
63a68af
support message translation in chat
lukaszpolowczyk Jun 19, 2023
579d856
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh Jan 10, 2024
81b8d61
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh May 9, 2024
3ca5c53
Merge branch 'matrix-org:develop' into lukaszpolowczyk/feat/support-m…
lukaszpolowczyk May 13, 2024
a915f5f
Update src/HtmlUtils.tsx
richvdh Jul 11, 2024
ea77f26
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh Jul 11, 2024
96753d3
Merge branch 'develop' into lukaszpolowczyk/feat/support-message-tran…
richvdh Jul 25, 2024
450becf
update snapshots
richvdh Jul 25, 2024
c0ae9fa
Convert TextualBody-test to use snapshots
richvdh Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/HtmlUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ export function bodyToHtml(content: IContent, highlights: Optional<string[]>, op
"mx_EventTile_body": true,
"mx_EventTile_bigEmoji": emojiBody,
"markdown-body": isHtmlMessage && !emojiBody,
"translate": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add a comment explaining a bit more about what this does, and why it is necessary? Surely it isn't normally necessary to mark things for translation explicitly?

Do I understand correctly that this is overriding a notranslate class somewhere else? Please say that in a comment if so.

Basically: imagine you are a developer reading this code for the first time, without the benefit of having read all of the conversation on element-hq/element-web#25594, and that you are trying to understand what this is for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that this is overriding a notranslate class somewhere else? Please say that in a comment if so.

@richvdh Yes.

The entire application currently has translation disabled using the notranslate class placed in the div#matrixchat element.
The translate class overrides the notranslate class that is in this element's ancestor.

richvdh marked this conversation as resolved.
Show resolved Hide resolved
});

let emojiBodyElements: JSX.Element[] | undefined;
Expand Down
Loading