This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Normalize class names of AppTile and create _AppTile.pcss
#11003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
- Add mx_AppTile by default - Cancel values inherited from mx_AppTile for now
mx_AppTile--mini is a variant of mx_AppTile
mx_AppTile--fullWidth is a variant of mx_AppTile
Those values are not required
mx_AppTileMenuBar* is defined by mx_AppTile
Add mx_AppTile--large if this.props.miniMode is not true This enables to remove declarations not universally shared by AppTile variants from "mx_AppTile", in order to remove declarations which are used to just unset inherited values - Apply border and background-color to "mx_AppTile--large" and "mx_AppTile--fullWidth" only, to remove unset from "mx_AppTile--mini" - Apply box-sizing to "mx_AppTile--large" only, to remove unset from "mx_AppTile--fullWidth" AND "mx_AppTile--mini"
Because "mx_AppTile", "mx_AppTile--fullWidth", and "mx_AppTile_mini" (mx_AppTile--mini) have covered all variants of AppTile and now we have "mx_AppTile" match all of them, it is no longer sensible to apply "mx_AppTile_persistedWrapper" to each selector. It can safely be nested in "mx_AppTile".
Because "mx_AppTile" class name is now globally applied, it has become redundant to apply "mx_AppTileBody" and "mx_AppTileBody--mini" to "mx_AppTile--fullWidth" and "mx_AppTile--mini", respectively. It is now fine to apply them to "mx_AppTile". Another theoretical possibility is a combination of "mx_AppTile--fullWidth" AND "mx_AppTileBody--mini", but it does not occur in reality because "mx_AppTile--fullWidth" is not applied on miniMode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.