Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented May 16, 2023

fixes element-hq/element-web#25381
fixes element-hq/element-web#25374

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 changed the title Let TimelinePanel not send a receipt if there is no event Let TimelinePanel only send a receipt if there is an event May 16, 2023
@weeman1337 weeman1337 added T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This affects the current release cycle and must be solved for a release to happen backport staging Label to automatically backport PR to staging branch labels May 16, 2023
@weeman1337 weeman1337 removed the backport staging Label to automatically backport PR to staging branch label May 16, 2023
@weeman1337 weeman1337 requested review from richvdh and t3chguy May 16, 2023 11:21
@weeman1337 weeman1337 marked this pull request as ready for review May 16, 2023 11:21
@weeman1337 weeman1337 requested a review from a team as a code owner May 16, 2023 11:21
@luixxiul
Copy link
Contributor

Will this PR fix this issue too? element-hq/element-web#25374

@weeman1337
Copy link
Contributor Author

Will this PR fix this issue too? vector-im/element-web#25374

Yes. Thanks for mentioning it 👍

@t3chguy t3chguy enabled auto-merge May 16, 2023 11:34
@t3chguy t3chguy added this pull request to the merge queue May 16, 2023
Merged via the queue into develop with commit acdbae3 May 16, 2023
@t3chguy t3chguy deleted the weeman1337/fix-timeline-panel-receipt branch May 16, 2023 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This affects the current release cycle and must be solved for a release to happen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky cypress tests due to Cannot read properties of undefined (reading 'getId') Flaky Cypress test - right panel behaves correctly

4 participants