Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update mx_AppLoading to improve maintainability #10783

Merged
merged 5 commits into from
May 8, 2023
Merged

Update mx_AppLoading to improve maintainability #10783

merged 5 commits into from
May 8, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 4, 2023

For element-hq/element-web#25269

This PR suggests to update mx_AppLoading of _AppsDrawer.pcss to:

  • Improve maintainability by nesting the rules, to prevent the rule from becoming an orphan, which can only be detected by manual labor
  • Clarify that AppLoading belongs to AppTile.tsx to extract its style rules from AppDrawer.pcss
  • Conform class name to the naming policy

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 4, 2023
@luixxiul luixxiul marked this pull request as ready for review May 4, 2023 09:50
@luixxiul luixxiul requested a review from a team as a code owner May 4, 2023 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants