This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Cypress test for unthreaded receipts not clobbering main thread ones #10769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
andybalaam
force-pushed
the
andybalaam/cypress-test-for-read-receipts
branch
from
376d3bf
to
e2998ec
Compare
germain-gg
approved these changes
May 2, 2023
Comment on lines
+117
to
+119
| // And we persuade the app to persist its state to indexeddb by reloading and waiting | ||
| cy.reload(); | ||
| cy.findByLabelText(`${selectedRoomName}`).should("exist"); |
There was a problem hiding this comment.
How does that piece of code persuade the accumulator to persist its state?
Is there a condition somewhere that flushes data to idb before Element is closed?
There was a problem hiding this comment.
It seems to flush immediately after reload. I don't know why 🤷
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for element-hq/element-web#24629
This change is marked as an internal change (Task), so will not be included in the changelog.