Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Apply strictNullChecks to src/Markdown.ts #10623

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Apply strictNullChecks to src/Markdown.ts #10623

merged 2 commits into from
Apr 17, 2023

Conversation

timjamello
Copy link
Contributor

@timjamello timjamello commented Apr 17, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Fixes element-hq/element-web#25086.

element-web notes: none

Signed-off-by: Timothy Amello whales_fun.0g@icloud.com

This change is marked as an internal change (Task), so will not be included in the changelog.

@timjamello timjamello requested a review from a team as a code owner April 17, 2023 01:39
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 17, 2023
@timjamello timjamello force-pushed the apply-strict-null-check-to-markdown branch from 8460467 to 883b46d Compare April 17, 2023 02:06
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 17, 2023
t3chguy
t3chguy approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@t3chguy t3chguy added this pull request to the merge queue Apr 17, 2023
Merged via the queue into matrix-org:develop with commit 1d9df7e Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply strictNullChecks to src/Markdown.ts
3 participants
@timjamello @t3chguy @kerryarchibald