Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Properly translate errors in AddThreepid.ts so they show up translated to the user but not in our logs #10432

Merged
merged 36 commits into from
Apr 14, 2023
Merged

Properly translate errors in AddThreepid.ts so they show up translated to the user but not in our logs #10432

merged 36 commits into from
Apr 14, 2023

Commits on Mar 22, 2023

  1. Properly translate errors in AddThreepid.ts 

    Part of element-hq/element-web#9597
    @MadLittleMods
    MadLittleMods committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    72c08a1 View commit details
    Browse the repository at this point in the history

  2. Use translated message

    @MadLittleMods
    MadLittleMods committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    777a4fc View commit details
    Browse the repository at this point in the history

  3. Avoid returning undefined ever

    @MadLittleMods
    MadLittleMods committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    167150d View commit details
    Browse the repository at this point in the history

  4. More usage

    @MadLittleMods
    MadLittleMods committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    4492ecc View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    8c24afb View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Introduce UserFriendlyError

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e57a11c View commit details
    Browse the repository at this point in the history

  2. Use UserFriendlyError

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ebbb455 View commit details
    Browse the repository at this point in the history

  3. Add more usage instead of normal error

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    b3d37fb View commit details
    Browse the repository at this point in the history

  4. Use types and translatedMessage

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    cf0ba20 View commit details
    Browse the repository at this point in the history

  5. Fix lints

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e557019 View commit details
    Browse the repository at this point in the history

  6. Update i18n although it's wrong

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e6f053a View commit details
    Browse the repository at this point in the history

  7. Use unknown for easier creation from try/catch

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8152c6b View commit details
    Browse the repository at this point in the history

  8. Use types

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d88d5f2 View commit details
    Browse the repository at this point in the history

  9. Use error types

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6e21c16 View commit details
    Browse the repository at this point in the history

  10. Use types

    @MadLittleMods
    MadLittleMods committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    078e24b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid

Conflicts:
	package.json
	src/@types/global.d.ts
	src/languageHandler.tsx
    @MadLittleMods
    MadLittleMods committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    924416c View commit details
    Browse the repository at this point in the history

  2. Update i18n strings

    @MadLittleMods
    MadLittleMods committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    1cd8ec0 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    306a1dc View commit details
    Browse the repository at this point in the history

  2. Remove generic re-label of HTTPError 

    See #10432 (comment)

The HTTPError already has a good label and it isn't even translated if we re-label it here in this way generically

Probably best to just remove in favor of thinking about a translations in general from the `matrix-js-sdk`, see matrix-org/matrix-js-sdk#1309
    @MadLittleMods
    MadLittleMods committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    ac02179 View commit details
    Browse the repository at this point in the history

  3. Make error message extraction generic

    @MadLittleMods
    MadLittleMods committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8675464 View commit details
    Browse the repository at this point in the history

  4. Update i18n strings

    @MadLittleMods
    MadLittleMods committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    529212c View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Add tests for email addresses

    @MadLittleMods
    MadLittleMods committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    edac565 View commit details
    Browse the repository at this point in the history

  2. More consistent error logging to actually see error in logs

    @MadLittleMods
    MadLittleMods committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    477db79 View commit details
    Browse the repository at this point in the history

  3. Consistent error handling

    @MadLittleMods
    MadLittleMods committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    629f429 View commit details
    Browse the repository at this point in the history

  4. Any is okay because we have a fallback

    @MadLittleMods
    MadLittleMods committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c2080ce View commit details
    Browse the repository at this point in the history

  5. Check error type

    @MadLittleMods
    MadLittleMods committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8ffeb6f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1b54ba6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    96ba896 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f8164d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    016341a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    5d74ef9 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ac67f1f View commit details
    Browse the repository at this point in the history

  2. Use dedicated mockResolvedValue function 

    See #10432 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    251df4d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    ae8bdaf View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    817190c View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Merge branch 'develop' into madlittlemods/9597-properly-translated-er… 

    …rors-in-AddThreepid
    @MadLittleMods
    MadLittleMods committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    ed00c59 View commit details
    Browse the repository at this point in the history