-
-
Notifications
You must be signed in to change notification settings - Fork 833
Conversation
36273d4
to
4f6bc2f
Compare
4f6bc2f
to
13e9b2c
Compare
Percy doesn't seem to take a screenshot of a toast yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, left some comments but feel free to ignore them.
Adding my ✅ but should be reviewed by design too.
.mx_Toast_title { | ||
display: flex; | ||
align-items: center; | ||
column-gap: 8px; | ||
width: 100%; | ||
box-sizing: border-box; | ||
margin-bottom: $spacing-16; | ||
|
||
h2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use the styled Heading component instead of the h2 tag and remove most of this style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except this style matches our h3
styling, which might cause a bit more fallout with changed snapshots etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mx_Toast_title_countIndicator
below also could be replaced with a Caption
component
This PR is put on hold. Need to clarify the scope. |
This PR will be replaced by a new one. |
closes element-hq/element-web#24490
Designs: element-hq/element-web#24490 (comment)
ℹ️ in design the toast is more on the left side.
I did not do this, because many of our Cypress tests would explode, because they currently don't care about the toasts.
Checklist
Here's what your changelog entry will look like:
✨ Features