This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use Room.findPredecessor when rendering RoomCreate tiles #10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
andybalaam
changed the title
andybalaam
force-pushed
the
andybalaam/RoomCreate-uses-getPredecessor
branch
from
90c97ef
to
e84eedd
Compare
andybalaam
force-pushed
the
andybalaam/RoomCreate-uses-getPredecessor
branch
from
e84eedd
to
c4afe9c
Compare
t3chguy
suggested changes
Jan 30, 2023
| // use a different predecessor (e.g. through MSC3946) and still display it | ||
| // in the timeline location of the create event. | ||
| const roomContext = useContext(RoomContext); | ||
| const predecessor = roomContext.room.findPredecessor(); |
There was a problem hiding this comment.
This doesn't look like it'll react to the predecessor changing due to a new/updated state event coming in?
There was a problem hiding this comment.
Addressed in 1b4c3f6 . Apologies for the rebase - fat-fingered it.
andybalaam
force-pushed
the
andybalaam/RoomCreate-uses-getPredecessor
branch
from
c4afe9c
to
9f2fbb7
Compare
|
Tests failed with |
|
Cypress failure is flaky test element-hq/element-web#24351 |
andybalaam
force-pushed
the
andybalaam/RoomCreate-uses-getPredecessor
branch
from
9f2fbb7
to
1b4c3f6
Compare
andybalaam
force-pushed
the
andybalaam/RoomCreate-uses-getPredecessor
branch
from
10c572b
to
ab1f6b6
Compare
t3chguy
reviewed
Feb 1, 2023
t3chguy
reviewed
Feb 1, 2023
t3chguy
approved these changes
Feb 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for MSC3946
Part of element-hq/element-web#24323
This change is marked as an internal change (Task), so will not be included in the changelog.