Update open in other tab message (#11916)

matrix-org · Nov 22, 2023 · ecc46ae · ecc46ae
1 parent 6f715ab
commit ecc46ae
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/src/components/structures/auth/SessionLockStolenView.tsx b/src/components/structures/auth/SessionLockStolenView.tsx
@@ -28,7 +28,7 @@ export function SessionLockStolenView(): JSX.Element {
 
     return (
         <SplashPage className="mx_SessionLockStolenView">
-            <h1>{_t("common|error")}</h1>
+            <h1>{_t("error_app_open_in_another_tab_title", { brand })}</h1>
             <h2>{_t("error_app_open_in_another_tab", { brand })}</h2>
         </SplashPage>
     );

diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
@@ -1056,7 +1056,8 @@
         "unknown_error_code": "unknown error code",
         "update_power_level": "Failed to change power level"
     },
-    "error_app_open_in_another_tab": "%(brand)s has been opened in another tab.",
+    "error_app_open_in_another_tab": "Switch to the other tab to connect to %(brand)s. This tab can now be closed.",
+    "error_app_open_in_another_tab_title": "%(brand)s is connected in another tab",
     "error_app_opened_in_another_window": "%(brand)s is open in another window. Click \"%(label)s\" to use %(brand)s here and disconnect the other window.",
     "error_database_closed_description": "This may be caused by having the app open in multiple tabs or due to clearing browser data.",
     "error_database_closed_title": "Database unexpectedly closed",

diff --git a/test/components/structures/MatrixChat-test.tsx b/test/components/structures/MatrixChat-test.tsx
@@ -1325,7 +1325,7 @@ describe("<MatrixChat />", () => {
                 await flushPromises();
 
                 // now we should see the error page
-                rendered.getByText("Test has been opened in another tab.");
+                rendered.getByText("Test is connected in another tab");
 
                 // let initCrypto complete, and check we don't get a modal
                 initCryptoCompleteDefer.resolve();

diff --git a/test/components/structures/__snapshots__/MatrixChat-test.tsx.snap b/test/components/structures/__snapshots__/MatrixChat-test.tsx.snap
@@ -6,10 +6,10 @@ exports[`<MatrixChat /> Multi-tab lockout shows the lockout page when a second t
     class="mx_SessionLockStolenView mx_SplashPage"
   >
     <h1>
-      Error
+      Test is connected in another tab
     </h1>
     <h2>
-      Test has been opened in another tab.
+      Switch to the other tab to connect to Test. This tab can now be closed.
     </h2>
   </main>
 </div>
@@ -22,10 +22,10 @@ exports[`<MatrixChat /> Multi-tab lockout shows the lockout page when a second t
       class="mx_SessionLockStolenView mx_SplashPage"
     >
       <h1>
-        Error
+        Test is connected in another tab
       </h1>
       <h2>
-        Test has been opened in another tab.
+        Switch to the other tab to connect to Test. This tab can now be closed.
       </h2>
     </main>
   </div>
@@ -38,10 +38,10 @@ exports[`<MatrixChat /> Multi-tab lockout shows the lockout page when a second t
     class="mx_SessionLockStolenView mx_SplashPage"
   >
     <h1>
-      Error
+      Test is connected in another tab
     </h1>
     <h2>
-      Test has been opened in another tab.
+      Switch to the other tab to connect to Test. This tab can now be closed.
     </h2>
   </main>
 </div>
@@ -53,10 +53,10 @@ exports[`<MatrixChat /> Multi-tab lockout shows the lockout page when a second t
     class="mx_SessionLockStolenView mx_SplashPage"
   >
     <h1>
-      Error
+      Test is connected in another tab
     </h1>
     <h2>
-      Test has been opened in another tab.
+      Switch to the other tab to connect to Test. This tab can now be closed.
     </h2>
   </main>
 </div>