Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
fix rainbow breaks compound emojis (#8245)
Browse files Browse the repository at this point in the history
* fix rainbow breaks compound emojis

* use lodash split method for text splitting and add a unit test to test the behaviour

* Update _RichText.scss

* Update colour-test.ts
  • Loading branch information
EECvision authored Apr 20, 2022
1 parent 4a38cbd commit 9a06558
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/utils/colour.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

import { split } from 'lodash';

export function textToHtmlRainbow(str: string): string {
const frequency = (2 * Math.PI) / str.length;

return Array.from(str)
return split(str, '')
.map((c, i) => {
if (c === " ") {
return c;
Expand Down
24 changes: 24 additions & 0 deletions test/utils/colour-test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
Copyright 2022 Emmanuel Ezeka <eec.studies@gmail.com>
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

import { textToHtmlRainbow } from "../../src/utils/colour";

describe("textToHtmlRainbow", () => {
it('correctly transform text to html without splitting the emoji in two', () => {
expect(textToHtmlRainbow('🐻')).toBe('<font color="#ff00be">🐻</font>');
expect(textToHtmlRainbow('🐕‍🦺')).toBe('<font color="#ff00be">🐕‍🦺</font>');
});
});

0 comments on commit 9a06558

Please sign in to comment.