fix race between setting canonical alias and creating aliases

matrix-org · Sep 16, 2016 · 08543a6 · 08543a6
1 parent 67565f8
commit 08543a6
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/src/components/views/room_settings/AliasSettings.js b/src/components/views/room_settings/AliasSettings.js
@@ -70,22 +70,6 @@ module.exports = React.createClass({
     saveSettings: function() {
         var promises = [];
 
-        // save new canonical alias
-        var oldCanonicalAlias = null;
-        if (this.props.canonicalAliasEvent) {
-            oldCanonicalAlias = this.props.canonicalAliasEvent.getContent().alias;
-        }
-        if (oldCanonicalAlias !== this.state.canonicalAlias) {
-            console.log("AliasSettings: Updating canonical alias");
-            promises.push(
-                MatrixClientPeg.get().sendStateEvent(
-                    this.props.roomId, "m.room.canonical_alias", {
-                        alias: this.state.canonicalAlias
-                    }, ""
-                )
-            );
-        }
-
         // save new aliases for m.room.aliases
         var aliasOperations = this.getAliasOperations();
         for (var i = 0; i < aliasOperations.length; i++) {
@@ -111,6 +95,23 @@ module.exports = React.createClass({
             }
         }
 
+
+        // save new canonical alias
+        var oldCanonicalAlias = null;
+        if (this.props.canonicalAliasEvent) {
+            oldCanonicalAlias = this.props.canonicalAliasEvent.getContent().alias;
+        }
+        if (oldCanonicalAlias !== this.state.canonicalAlias) {
+            console.log("AliasSettings: Updating canonical alias");
+            promises = [ q.all(promises).then(
+                MatrixClientPeg.get().sendStateEvent(
+                    this.props.roomId, "m.room.canonical_alias", {
+                        alias: this.state.canonicalAlias
+                    }, ""
+                )
+            ) ];
+        }
+
         return promises;
     },