Configure widget permissions using ModuleRunner.instance.invoke #11
Conversation
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
|
@andybalaam it looks like you've already done a bunch of thinking about this, so I'm afraid I'm going to throw it over the wall in your direction! |
|
Hi @andybalaam could you please provide feedback on this PR? |
@maheichyk I'm sorry for the delay on this. I will take a look today. |
|
@maheichyk this looks great. Please could we have a small test similar to what you did in #9 and then we'll be ready to merge this. Thanks again for your work on this and your patience. |
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks good - requesting a test that validates the flow.
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
|
@andybalaam thanks for the feedback! Test was added, please have a look. |
|
If test is fine, would be great maybe to have a new version of |
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
This looks great, thank you!
|
@maheichyk new release 0.0.4 published at https://www.npmjs.com/package/@matrix-org/react-sdk-module-api |
4 participants
This PR suggests changes to module API to support customization of widget permissions using
ModuleRunner.instance.invokeas discussed here: #9 (comment)