Fix setup.cfg for release
#8
Conversation
| [metadata] | ||
| name = matrix_common | ||
| description = "Common utilities for Synapse, Sydent and Sygnal" | ||
| description = Common utilities for Synapse, Sydent and Sygnal |
There was a problem hiding this comment.
The quotation marks get included verbatim otherwise
| packages = | ||
| matrix_common |
There was a problem hiding this comment.
Is this the right way to not publish an empty package?
There was a problem hiding this comment.
I'm not really sure what you mean by this? I think usually you can either specify the packages manually, as you did, or use find: (and potentially exclude any tests, etc.)
There was a problem hiding this comment.
I was uncertain at the time because I was expecting synapse-module-cookiecutter-template to work out of the box.
I've PRed an equivalent change into the template so it's all okay now.
setup.cfg
Outdated
| [options] | ||
| packages = | ||
| matrix_common | ||
| python_requires = >= 3.7 |
There was a problem hiding this comment.
Synapse still supports 3.6, but only for a few more weeks. Not sure of your plan for when we intend to use this?
There was a problem hiding this comment.
Good point. I'm hoping to use this sooner rather than later, so we really ought to support 3.6 for now.
|
That last commit should say "3.6". As for |
I figured it was something like that, we'll figure that out as we go I suppose! Changes look good |
|
I'm going to merge this, but won't release yet. |
We should really write this down, but it seems like we should be using Twisted-specific stuff instead of aiounittest anyway — it's fairly likely you'll just want to cut it out (though we should figure out an equivalent for Twisted) |
Preview: https://test.pypi.org/project/matrix-common/