Lazy loading: fix end-to-end encryption rooms #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bwindels
commented
Aug 6, 2018
•
bwindels
commented
- don't break device key tracking
- when offline, make sure you can send messages in e2e room when back online
when loading the encrypted events from storage, the code would wait for the encryption target users, which would never come because you would only load them when viewing the room. This disabled starting to track the devices in the room when the inhibitDeviceQuery is set.
dbkr
reviewed
Aug 7, 2018
src/utils.js
Outdated
| }); | ||
| promise.resolve = resolve; | ||
| return promise; | ||
| }; |
There was a problem hiding this comment.
I think bluebird are fairly keen to avoid to avoid you doing this, ie. it's very strongly geared towards using new Promise() directly, so we should probably drink their kool-aid rather than try to work against the library.
There was a problem hiding this comment.
As all our target platforms all support native promises, it would be nice to drop bluebird at some point, and just use the DOM APIs on Promise. But given the changes we discussed this morning, I don't need this anymore, so getting rid of it.
bwindels
force-pushed
the
bwindels/e2e_enc_ll
branch
from
40703d6
to
0ae0770
Compare
22 tasks
dbkr
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.