take into account homoglyphs when calculating similar display names #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent homoglyph attacks Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
|
lgtm! |
Collaborator
|
It appears CI is still puzzled about lock files that don't exist in this repo... Perhaps a rebase and force push would do it? @t3chguy, are you interested in updating this? |
…ix-org/matrix-js-sdk into t3chguy/unhomoglyph
Member
Author
|
I guess it wants me to update the |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
jryans
approved these changes
Dec 20, 2018
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks for the contribution! It looks good to me as well. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent homoglyph attacks
for riot-web requires element-hq/element-web#7093
Fixes element-hq/element-web#5826
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com