Skip to content

Stop re-adding displayname/avatar fields to leave/ban state events #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Stop re-adding displayname/avatar fields to leave/ban state events #5011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fced90
Stop silently re-adding the `displayname` and `avatar` fields to leav…
gingershaped Sep 16, 2025
f6573c0
Merge branch 'develop' into remove-member-event-patching
gingershaped Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/models/room-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,19 +464,6 @@ export class RoomState extends TypedEventEmitter<EmittedEvents, EventHandlerMap>

if (event.getType() === EventType.RoomMember) {
const userId = event.getStateKey()!;

// leave events apparently elide the displayname or avatar_url,
// so let's fake one up so that we don't leak user ids
// into the timeline
if (
event.getContent().membership === KnownMembership.Leave ||
event.getContent().membership === KnownMembership.Ban
) {
event.getContent().avatar_url = event.getContent().avatar_url || event.getPrevContent().avatar_url;
event.getContent().displayname =
event.getContent().displayname || event.getPrevContent().displayname;
}

const member = this.getOrCreateMember(userId, event);
member.setMembershipEvent(event, this);
this.updateMember(member);
Expand Down