Skip to content

Remove custom org.matrix.msc4075.rtc.notification.parent relation type #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2025
Merged

Remove custom org.matrix.msc4075.rtc.notification.parent relation type #4979

merged 3 commits into from
Sep 2, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Aug 26, 2025 •
edited
Loading

The MSC4075 now uses m.reference instead
Signed-off-by: Timo K toger5@hotmail.de

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5 toger5 requested review from a team as code owners August 26, 2025 12:45
fkwp
fkwp approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@fkwp fkwp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fkwp fkwp added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 1, 2025
@fkwp fkwp added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 1, 2025
@fkwp fkwp added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 1, 2025
@richvdh
Copy link
Member

richvdh commented Sep 1, 2025

Quick reminder to please make sure we have issues open to track tests we believe to be flaky ...

@fkwp fkwp added this pull request to the merge queue Sep 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2025
@toger5
Remove custom org.matrix.msc4075.rtc.notification.parent relation t…
e4a9944 
…ype (#4979)

* Remove custom `org.matrix.msc4075.rtc.notification.parent` relation type

Signed-off-by: Timo K <toger5@hotmail.de>

* fix test

Signed-off-by: Timo K <toger5@hotmail.de>

---------

Signed-off-by: Timo K <toger5@hotmail.de>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 1, 2025
@toger5 @BillCarsonFr
Remove custom org.matrix.msc4075.rtc.notification.parent relation type
8db1ac5 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 @BillCarsonFr
fix test
9396d68 
Signed-off-by: Timo K <toger5@hotmail.de>
@BillCarsonFr BillCarsonFr force-pushed the toger5/remove-custom-relation-type-for-rtc-notification branch from 260bd07 to 9396d68 Compare September 2, 2025 08:08
@fkwp fkwp added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@BillCarsonFr BillCarsonFr added this pull request to the merge queue Sep 2, 2025
Merged via the queue into develop with commit d62c658 Sep 2, 2025
32 checks passed
@BillCarsonFr BillCarsonFr deleted the toger5/remove-custom-relation-type-for-rtc-notification branch September 2, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@fkwp fkwp fkwp approved these changes

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toger5 @richvdh @florianduros @fkwp @BillCarsonFr