Make a MatrixRTCSession emit once the RTCNotification is sent #4976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
added a commit
to element-hq/element-call
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
added a commit
to element-hq/element-call
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
added a commit
to element-hq/element-call
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
added
the
T-Feature
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
force-pushed
the
toger5/emit-on-notification-sent
branch
from
1d62bcd to
a9dc1c3
Compare
toger5
changed the title
toger5
added a commit
to element-hq/element-call
that referenced
this pull request
Aug 25, 2025
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
added
T-Enhancement
and removed
T-Feature
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new event to the MatrixRTC session. An event that is emitted once the session has taken over its responsibilty of sending the notification event.
Context:
Element call now sends the notificaition event (the matrix event that makes other clients ring) instead of the client that encapsuls element call.
In element call we need to know if the js-sdk decided to actually send this notification or not. One example why it might not send it is: There is already someone in the call -> we are not the call starter -> we will not send a ring notification.
If it did send the notification (ring) and this new event emits it allows EC to build a ux around it. Commuication to the user that they are in "waiting for other participants to join" state.
Signed-off-by: Timo K toger5@hotmail.de
Checklist
public/exportedsymbols have accurate TSDoc documentation.