Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/simplify Promises in MatrixRTCSession #4466

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Refactor/simplify Promises in MatrixRTCSession #4466

wants to merge 4 commits into from
+19 −17

Commits on Oct 18, 2024

  1. Refactor/simplify Promises in MatrixRTCSession

    @AndrewFerr
    AndrewFerr committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9382763 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Update src/matrixrtc/MatrixRTCSession.ts 

    Co-authored-by: Hugh Nimmo-Smith <hughns@users.noreply.github.com>
    @AndrewFerr @hughns
    AndrewFerr and hughns authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    475a37d View commit details
    Browse the repository at this point in the history

  2. Fix+document+test leaveRoomSession's return value

    @AndrewFerr
    AndrewFerr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0383056 View commit details
    Browse the repository at this point in the history

  3. Throw instead of using expect in teardown 

    because lint rules forbid using expect outside of test functions
    @AndrewFerr
    AndrewFerr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    75174e9 View commit details
    Browse the repository at this point in the history