- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 648
 
Update dependency fake-indexeddb to v6 #4224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            renovate
  wants to merge
  1
  commit into
  develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
renovate/fake-indexeddb-6.x
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
    
  dbkr 
      added a commit
      that referenced
      this pull request
    
      May 29, 2024 
    
    
      
  
    
      
    
  
dumbmatter/fakeIndexedDB#93 causes a bunch of tests to start failing because the fake timers need running in order for fake indexeddb to work. It also seems to cause failures to bleed between tests somehow if fake timers are enabled/disabled. This keeps all the fake timer tests in one suite and all the others in another, which appears to work. This should allow #4224 to be merged.
      
        
      
      
  
    4 tasks
  
    
  github-merge-queue bot
      pushed a commit
      that referenced
      this pull request
    
      May 30, 2024 
    
    
      
  
    
      
    
  
dumbmatter/fakeIndexedDB#93 causes a bunch of tests to start failing because the fake timers need running in order for fake indexeddb to work. It also seems to cause failures to bleed between tests somehow if fake timers are enabled/disabled. This keeps all the fake timer tests in one suite and all the others in another, which appears to work. This should allow #4224 to be merged.
ea44ea1    to
    000aea0      
    Compare
  
    | 
           Eugh, this breaks a whole bunch of our tests because anything that uses fake timers now needs to advance them for indexeddb to work. I fixed the queueToDevice ones in #4225 but now there a load more. Really feels like fake-indexeddb should have an option to pass a timer function in to bypass the fake timers or something.  | 
    
9289989    to
    8a513f1      
    Compare
  
    8a513f1    to
    042303f      
    Compare
  
    042303f    to
    f74933d      
    Compare
  
    f74933d    to
    ea79fd0      
    Compare
  
    80ee6bb    to
    e7cbbf8      
    Compare
  
    e7cbbf8    to
    1e39e62      
    Compare
  
    1e39e62    to
    2691796      
    Compare
  
    2691796    to
    c49e422      
    Compare
  
    c49e422    to
    ca94654      
    Compare
  
    ca94654    to
    c10a7ed      
    Compare
  
    47e0a24    to
    cd8ccc3      
    Compare
  
    cd8ccc3    to
    8205fa0      
    Compare
  
    8205fa0    to
    4d61110      
    Compare
  
    4d61110    to
    778a612      
    Compare
  
    778a612    to
    97ae3d0      
    Compare
  
    97ae3d0    to
    5888d20      
    Compare
  
    5888d20    to
    b273535      
    Compare
  
    b273535    to
    14dffa7      
    Compare
  
    14dffa7    to
    996bd9b      
    Compare
  
    996bd9b    to
    6c93986      
    Compare
  
    6c93986    to
    707e294      
    Compare
  
    707e294    to
    3cf6913      
    Compare
  
    3cf6913    to
    0b026a9      
    Compare
  
    0b026a9    to
    053be76      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR contains the following updates:
^5.0.2->^6.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
dumbmatter/fakeIndexedDB (fake-indexeddb)
v6.2.4Compare Source
Several small bug fixes to more correctly handle various edge cases and increase the number of passing tests from the Web Platform Tests (#147, #155, #157 by @dumbmatter; #156, #158, #159, #160 by @nolanlawson)
Improvements to testing infrastructure, allowing more Web Platform Tests to run (#148 by @dumbmatter; #150, #151, #152, #153, #154 by @nolanlawson)
Automated and updated the Web Platform Tests comparison table in the README (#161 by @nolanlawson)
v6.2.3Compare Source
v6.2.2Compare Source
indexedDBvariable created byfake-indexeddb/auto(such as withindexedDB = new IDBFactory();) was no longer working (#135 by @nolanlawson)v6.2.1Compare Source
IDBDatabasevariable created by a CommonJS require offake-indexeddb/auto, which was broken in v6.2.0 (#131 by @nolanlawson)v6.2.0Compare Source
indexedDBvariable created byfake-indexeddb/auto(such as withindexedDB = new IDBFactory();) was no longer working (#135 by @nolanlawson)v6.1.0Compare Source
Added support for new IndexedDB features: querying keys and values at the same time with
getAllRecords, and passing a descending direction intogetAll/getAllKeys. (#112 by @nolanlawson)Better DOMStringList polyfill that doesn't include various inappropriate array methods. (#66 by @dumbmatter)
Updated the Web Platform Tests from 2019 to 2025 which improved test coverage and uncovered a few minor bugs that were fixed. (#117 by @nolanlawson)
v6.0.1Compare Source
v6.0.0Compare Source
I made this a new major version because it includes a few changes that could in theory break something in some weird situations. But I think the vast majority of users (possibly all users?) won't have any issue upgrading.
#48 - Switched to using
DOMExceptionerrors rather than normal errors, since that's what the IndexedDB spec says to use, and Node.js now has a built-in DOMException in all supported versions.#93 - @bryan-codaio made the latest tweak to event scheduling, this time improving how
setImmediateis used in some situations where people are mocking timers.#99 - @sjnho fixed handling of
Dateobjects to account for some edge cases, including jsdom overriding the nativeDateconstructor.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.