-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend stats summary with call device and user count based on room state #3424
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
82303b9
send expected peer connections to posthog.
toger5 91dfdd4
add tests
toger5 538b787
change GroupCallStats initialized
toger5 0bc2bfd
prettier
toger5 dd21ee2
more test and catch for promise
toger5 d383d2d
Merge branch 'develop' into splitBrainIndicatorRoomState
toger5 b23b8fd
seperate the participant logic in a summary extend function
toger5 45e8ae4
remove unused
toger5 2c512c8
Merge branch 'develop' into splitBrainIndicatorRoomState
toger5 1b42313
rename summaryStatsReportGatherer to "Reporter"
toger5 1f99cd0
review
toger5 c4e3b90
Update src/webrtc/stats/groupCallStats.ts
toger5 39465e3
revert rename
toger5 0fd11ac
Update all non-major dependencies (#3433)
renovate[bot] 600f26d
Update definitelyTyped (#3430)
renovate[bot] de34d24
Export FALLBACK_ICE_SERVER (#3429)
t3chguy 6b60287
Add an integration test for verification (#3436)
richvdh 44ed483
Always show a summary after Jest tests (#3440)
richvdh dd23e4b
Use correct /v3 prefix for /refresh (#3016)
davidisaaclee 5976d69
Update Mutual Rooms (MSC2666) support (#3381)
ShadowJonathan 3895fbb
GHA: build and cypress-test a copy of element-web after each push (#3…
richvdh 6f79cd2
Fix downstream-artifacts build (#3443)
richvdh 1e2f701
Fix edge cases around 2nd order relations and threads (#3437)
t3chguy d4e3452
Make sliding sync linearize processing of sync requests (#3442)
t3chguy 8ccbb8d
Disable downstream artifacts build for develop branch (#3444)
richvdh e1ce16a
Export thread-related types from SDK (#3447)
stas-demydiuk a21736c
Integration test for QR code verification (#3439)
richvdh 9afad10
Add `getShowSasCallbacks`, `getShowQrCodeCallbacks` to VerifierBase (…
richvdh 2c94bae
Fix changelog_head.py script to be Python 3 compatible
RiotRobot 8bab6cd
Prepare changelog for v25.2.0-rc.1
RiotRobot 1aeaba5
v25.2.0-rc.1
RiotRobot b0a73fc
Fix tsconfig-build.json
RiotRobot ec3fd91
Prepare changelog for v25.2.0-rc.2
RiotRobot 1c67b38
v25.2.0-rc.2
RiotRobot a3c1656
Fix docs deployment
t3chguy 6969446
Prepare changelog for v25.2.0-rc.3
RiotRobot 9a79554
v25.2.0-rc.3
RiotRobot 6ad2cc3
Prepare changelog for v25.2.0-rc.4
RiotRobot 4c250b5
v25.2.0-rc.4
RiotRobot a8b327e
[Backport staging] Attempt a potential workaround for stuck notifs (#…
RiotRobot e255bab
Prepare changelog for v25.2.0-rc.5
RiotRobot bf107ac
v25.2.0-rc.5
RiotRobot e53368a
[Backport staging] Fix mark as unread button (#3401)
RiotRobot 29b9889
Prepare changelog for v26.0.0-rc.1
RiotRobot 144edca
v26.0.0-rc.1
RiotRobot e7a02b0
Prepare changelog for v26.0.0
RiotRobot 3e1b3d9
v26.0.0
RiotRobot 4c219cf
Resetting package fields for development
RiotRobot accd4a5
use cli.canSupport to determine intentional mentions support (#3445)
0fcfe9c
git fixup
toger5 4c09840
import updates
toger5 dd58296
merge with develop
toger5 7a19ddf
dont revert enricos change
toger5 d2c8b04
temp rename for lowercase
toger5 1eb1fdb
lowercase
toger5 ce5e00f
Merge branch 'develop' into toger5/splitbrainIndicatorRoomState
toger5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the names are interpretations of the actual statistics. I would name the values according to their real meaning and do the interpretation in Posthog. And I would also add the joined users in the room. Because it is unusual for a user to take part in a conference with several devices. If it happens too often, we can use this to identify a caching issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the devices more comparable with the peerConnections i only count the devices without the "local" device. I changed it to
oppDevicesInCall
andoppUsersInCall
.