Improve logging in legacy megolm code #3043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than manually adding `in ${this.roomId}` to each log line, use a
PrefixedLogger to achieve the same effect more consistently.
Where we log a list of devices, we don't need the whole deviceinfo, just the device id. All that noise makes it very hard to read the logs.
artcodespace
approved these changes
Jan 10, 2023
artcodespace
left a comment
artcodespace
left a comment
There was a problem hiding this comment.
Looks good to me, the only notes I've added are all on the same subject and just there for consistency's sake
Member
Author
|
@alunturner thanks for the suggestions - I meant to do the conversion from backticks to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of changes to try to improve the quality of the logging within the crypto subsystem; we try to reduce the noise, but in its stead add a little more logging to try and understand what is going on with element-hq/element-web#23269.
Suggest reviewing commit-by-commit.
This change is marked as an internal change (Task), so will not be included in the changelog.