Skip to content

Add login flow types from matrix-react-sdk #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 11, 2022
Merged

Add login flow types from matrix-react-sdk #2633

merged 5 commits into from
Sep 11, 2022

Conversation

@hughns
Copy link
Member

@hughns hughns commented Sep 1, 2022 •
edited
Loading

The corresponding PR for matrix-react-sdk is matrix-org/matrix-react-sdk#9232

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@hughns hughns added the T-Task Tasks for the team like planning label Sep 1, 2022
@hughns hughns mentioned this pull request Sep 1, 2022
Merged
3 tasks
@hughns
Copy link
Member Author

hughns commented Sep 1, 2022

The failing tests are for queueToDevice() which has not been touched.

@hughns hughns marked this pull request as ready for review September 1, 2022 19:32
@hughns hughns requested a review from a team as a code owner September 1, 2022 19:32
duxovni
duxovni approved these changes Sep 1, 2022
View reviewed changes
@hughns @duxovni
Update src/@types/auth.ts
2bb22c6 
Co-authored-by: Faye Duxovni <fayed@element.io>
@hughns hughns mentioned this pull request Sep 11, 2022
Merged
5 tasks
@hughns hughns merged commit 583e480 into develop Sep 11, 2022
@hughns hughns deleted the hughns/login-flows-types branch September 11, 2022 20:50
t3chguy added a commit that referenced this pull request Sep 12, 2022
@t3chguy
Revert "Add login flow types from matrix-react-sdk (#2633)"
f0c26c6 
This reverts commit 583e480
@t3chguy t3chguy mentioned this pull request Sep 12, 2022
Merged
t3chguy added a commit that referenced this pull request Sep 12, 2022
@t3chguy @hughns
Revert "Add login flow types from matrix-react-sdk (#2633)" (#2661)
afa3b37 
* Revert "Add login flow types from matrix-react-sdk (#2633)"

This reverts commit 583e480

* Leave login flow types, only revert method return type

Co-authored-by: Hugh Nimmo-Smith <hughns@matrix.org>
turt2live
turt2live reviewed Sep 12, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turt2live turt2live turt2live left review comments

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

+1 more reviewer

@duxovni duxovni duxovni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Tasks for the team like planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hughns @turt2live @duxovni